Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Remove the support for 'is' #7930

Merged
merged 4 commits into from
May 8, 2023

Conversation

lin-hitonami
Copy link
Contributor

@lin-hitonami lin-hitonami commented May 5, 2023

Issue: #

Brief Summary

🤖 Generated by Copilot at 661bbce

Remove is and is not operators from Taichi scope and update test case. This change prevents confusion and errors when comparing Taichi tensors and scalars.

Walkthrough

🤖 Generated by Copilot at 661bbce

  • Remove support for is and is not operators in Taichi scope and raise syntax error instead (link, link, link)

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit d066572
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6455ea224869130008bf21c1
😎 Deploy Preview https://deploy-preview-7930--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lin-hitonami lin-hitonami added this to the v1.6.0 milestone May 6, 2023
@lin-hitonami lin-hitonami merged commit bdaab17 into taichi-dev:master May 8, 2023
@lin-hitonami lin-hitonami deleted the remove-is branch May 8, 2023 03:21
feisuzhu pushed a commit that referenced this pull request May 9, 2023
Issue: #

### Brief Summary

<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 661bbce</samp>

Remove `is` and `is not` operators from Taichi scope and update test
case. This change prevents confusion and errors when comparing Taichi
tensors and scalars.

### Walkthrough

<!--
copilot:walkthrough
-->
### <samp>🤖 Generated by Copilot at 661bbce</samp>

* Remove support for `is` and `is not` operators in Taichi scope and
raise syntax error instead
([link](https://github.com/taichi-dev/taichi/pull/7930/files?diff=unified&w=0#diff-3e22417ffade4af0564893b98dc5101d714b8ba6fd4423ab5bc5129e360fee8fL1026-L1027),
[link](https://github.com/taichi-dev/taichi/pull/7930/files?diff=unified&w=0#diff-3e22417ffade4af0564893b98dc5101d714b8ba6fd4423ab5bc5129e360fee8fL1034-R1038),
[link](https://github.com/taichi-dev/taichi/pull/7930/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L102-R103))
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: #

### Brief Summary

<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 661bbce</samp>

Remove `is` and `is not` operators from Taichi scope and update test
case. This change prevents confusion and errors when comparing Taichi
tensors and scalars.

### Walkthrough

<!--
copilot:walkthrough
-->
### <samp>🤖 Generated by Copilot at 661bbce</samp>

* Remove support for `is` and `is not` operators in Taichi scope and
raise syntax error instead
([link](https://github.com/taichi-dev/taichi/pull/7930/files?diff=unified&w=0#diff-3e22417ffade4af0564893b98dc5101d714b8ba6fd4423ab5bc5129e360fee8fL1026-L1027),
[link](https://github.com/taichi-dev/taichi/pull/7930/files?diff=unified&w=0#diff-3e22417ffade4af0564893b98dc5101d714b8ba6fd4423ab5bc5129e360fee8fL1034-R1038),
[link](https://github.com/taichi-dev/taichi/pull/7930/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L102-R103))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants