Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Remove a.atomic(b) #7925

Merged
merged 4 commits into from
May 6, 2023
Merged

Conversation

lin-hitonami
Copy link
Contributor

@lin-hitonami lin-hitonami commented May 5, 2023

Issue: #

Brief Summary

🤖 Generated by Copilot at cf84147

Removed deprecated and unused code related to atomic operations. Updated tests to use the new ti.atomic_op syntax.

Walkthrough

🤖 Generated by Copilot at cf84147

  • Remove deprecated atomic operations from TaichiOperations class and simplify code (link, link)
  • Remove test function for deprecated atomic operations from test_deprecation.py and update test suite (link)

@netlify
Copy link

netlify bot commented May 5, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit d1a375f
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6455ee9e31301100084c4627
😎 Deploy Preview https://deploy-preview-7925--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lin-hitonami lin-hitonami added this to the v1.6.0 milestone May 5, 2023
@lin-hitonami
Copy link
Contributor Author

/rebase

@lin-hitonami lin-hitonami merged commit 92e10df into taichi-dev:master May 6, 2023
@lin-hitonami lin-hitonami deleted the remove-atomic branch May 6, 2023 09:56
feisuzhu pushed a commit that referenced this pull request May 9, 2023
Issue: #

<!--
copilot:summary
-->

Removed deprecated and unused code related to atomic operations. Updated
tests to use the new `ti.atomic_op` syntax.

<!--
copilot:walkthrough
-->

* Remove deprecated atomic operations from `TaichiOperations` class and
simplify code
([link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-acea46764263e4987a75c9fc436ab4a70c6f1025253a9adc4d70aa1eb030dbebL1-L2),
[link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-acea46764263e4987a75c9fc436ab4a70c6f1025253a9adc4d70aa1eb030dbebL11-L28))
* Remove test function for deprecated atomic operations from
`test_deprecation.py` and update test suite
([link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L12-L26))
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: #

### Brief Summary

<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at cf84147</samp>

Removed deprecated and unused code related to atomic operations. Updated
tests to use the new `ti.atomic_op` syntax.

### Walkthrough

<!--
copilot:walkthrough
-->
### <samp>🤖 Generated by Copilot at cf84147</samp>

* Remove deprecated atomic operations from `TaichiOperations` class and
simplify code
([link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-acea46764263e4987a75c9fc436ab4a70c6f1025253a9adc4d70aa1eb030dbebL1-L2),
[link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-acea46764263e4987a75c9fc436ab4a70c6f1025253a9adc4d70aa1eb030dbebL11-L28))
* Remove test function for deprecated atomic operations from
`test_deprecation.py` and update test suite
([link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L12-L26))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants