-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lang] Remove a.atomic(b) #7925
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
/rebase |
taichi-gardener
force-pushed
the
remove-atomic
branch
from
May 6, 2023 04:43
cf84147
to
7735030
Compare
ailzhang
approved these changes
May 6, 2023
feisuzhu
pushed a commit
that referenced
this pull request
May 9, 2023
Issue: # <!-- copilot:summary --> Removed deprecated and unused code related to atomic operations. Updated tests to use the new `ti.atomic_op` syntax. <!-- copilot:walkthrough --> * Remove deprecated atomic operations from `TaichiOperations` class and simplify code ([link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-acea46764263e4987a75c9fc436ab4a70c6f1025253a9adc4d70aa1eb030dbebL1-L2), [link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-acea46764263e4987a75c9fc436ab4a70c6f1025253a9adc4d70aa1eb030dbebL11-L28)) * Remove test function for deprecated atomic operations from `test_deprecation.py` and update test suite ([link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L12-L26))
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: # ### Brief Summary <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at cf84147</samp> Removed deprecated and unused code related to atomic operations. Updated tests to use the new `ti.atomic_op` syntax. ### Walkthrough <!-- copilot:walkthrough --> ### <samp>🤖 Generated by Copilot at cf84147</samp> * Remove deprecated atomic operations from `TaichiOperations` class and simplify code ([link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-acea46764263e4987a75c9fc436ab4a70c6f1025253a9adc4d70aa1eb030dbebL1-L2), [link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-acea46764263e4987a75c9fc436ab4a70c6f1025253a9adc4d70aa1eb030dbebL11-L28)) * Remove test function for deprecated atomic operations from `test_deprecation.py` and update test suite ([link](https://github.com/taichi-dev/taichi/pull/7925/files?diff=unified&w=0#diff-8981be068a363e39524dc2e29d28d4c13a097d0037fc3a1176b249ce5bf35ef8L12-L26))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
🤖 Generated by Copilot at cf84147
Removed deprecated and unused code related to atomic operations. Updated tests to use the new
ti.atomic_op
syntax.Walkthrough
🤖 Generated by Copilot at cf84147
TaichiOperations
class and simplify code (link, link)test_deprecation.py
and update test suite (link)