Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Warn driver version if it doesn't support memory pool. #7912

Merged
merged 2 commits into from
May 10, 2023

Conversation

turbo0628
Copy link
Member

@turbo0628 turbo0628 commented Apr 27, 2023

Fixes #7826

Brief Summary

🤖 Generated by Copilot at 8d158a9

Check driver version and support for CUDA memory pools in CUDADriverContext constructor. Warn users and avoid errors if driver is too old.

Walkthrough

🤖 Generated by Copilot at 8d158a9

  • Add memory pool support for CUDA devices (link, F0

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


haidong lan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@netlify
Copy link

netlify bot commented Apr 27, 2023

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 19bb317
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/644a30a233bee00008fb4ee9

@turbo0628 turbo0628 requested a review from lin-hitonami April 27, 2023 08:21
Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@feisuzhu feisuzhu merged commit 0cceae7 into taichi-dev:master May 10, 2023
feisuzhu pushed a commit that referenced this pull request May 10, 2023
Fixes #7826 

### Brief Summary

<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 8d158a9</samp>

Check driver version and support for CUDA memory pools in
`CUDADriverContext` constructor. Warn users and avoid errors if driver
is too old.

### Walkthrough

<!--
copilot:walkthrough
-->
### <samp>🤖 Generated by Copilot at 8d158a9</samp>

* Add memory pool support for CUDA devices
([link](https://github.com/taichi-dev/taichi/pull/7912/files?diff=unified&w=0#diff-03914c736ef6eca99a9941fae49ef3ee93a9ad1c9a690e31dd1e8862183c154aL33-R47),
F0

---------

Co-authored-by: haidong lan <haidonglan@taichigraphics.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
…-dev#7912)

Fixes taichi-dev#7826 

### Brief Summary

<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at 8d158a9</samp>

Check driver version and support for CUDA memory pools in
`CUDADriverContext` constructor. Warn users and avoid errors if driver
is too old.

### Walkthrough

<!--
copilot:walkthrough
-->
### <samp>🤖 Generated by Copilot at 8d158a9</samp>

* Add memory pool support for CUDA devices
([link](https://github.com/taichi-dev/taichi/pull/7912/files?diff=unified&w=0#diff-03914c736ef6eca99a9941fae49ef3ee93a9ad1c9a690e31dd1e8862183c154aL33-R47),
F0

---------

Co-authored-by: haidong lan <haidonglan@taichigraphics.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] cuDeviceGetDefaultMemPool is being used on older drivers
4 participants