[aot] Remove unused AotDataConverter #7799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview canceled.
|
lin-hitonami
requested review from
PENGUINLIONG,
ailzhang,
bobcao3,
jim19930609 and
PGZXB
PGZXB
approved these changes
Apr 13, 2023
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
Issue: # ### Brief Summary <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at cc28232</samp> Remove `AotDataConverter` class <s>and simplify AOT module format. This class was used to convert between different data structures for AOT modules, but it is no longer needed as the source structure now uses protobuf messages. This change makes the AOT module format more consistent and portable.</s> ### Walkthrough <!-- copilot:walkthrough --> ### <samp>🤖 Generated by Copilot at cc28232</samp> * Remove `AotDataConverter` class and its usages, as it is no longer needed to convert between TaichiAotData and aot::ModuleData structures ([link](https://github.com/taichi-dev/taichi/pull/7799/files?diff=unified&w=0#diff-be8b774a8052c4122479b69798509100af7e53eb36da000cc42877863bcfbf89L13-L104), F0L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #
Brief Summary
🤖 Generated by Copilot at cc28232
Remove
AotDataConverterclassand simplify AOT module format. This class was used to convert between different data structures for AOT modules, but it is no longer needed as the source structure now uses protobuf messages. This change makes the AOT module format more consistent and portable.Walkthrough
🤖 Generated by Copilot at cc28232
AotDataConverterclass and its usages, as it is no longer needed to convert between TaichiAotData and aot::ModuleData structures (link, F0L