Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Avoid redundant cache loading #7741

Merged
merged 3 commits into from
Apr 4, 2023
Merged

[bug] Avoid redundant cache loading #7741

merged 3 commits into from
Apr 4, 2023

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Apr 4, 2023 •
edited
Loading

Issue: #7002

Brief Summary

🤖 Generated by Copilot at f2ee059

Improve kernel compilation manager efficiency by avoiding redundant cache loading.

Walkthrough

🤖 Generated by Copilot at f2ee059

  • Add a check for existing kernel data to avoid redundant loading (link)

@netlify
Copy link

netlify bot commented Apr 4, 2023 •
edited
Loading

✅ Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit bfea899
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/642c240ca241f00008fb67f4

@PGZXB PGZXB changed the title [bug] Avoid re-loading offline-cached-kernel [bug] Avoid redundant cache loading Apr 4, 2023
@PGZXB PGZXB requested review from ailzhang and lin-hitonami April 4, 2023 11:45
ailzhang
ailzhang approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PGZXB PGZXB merged commit d919d75 into taichi-dev:master Apr 4, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
@PGZXB @quadpixels
[bug] Avoid redundant cache loading (taichi-dev#7741)
2e03f82 
Issue: taichi-dev#7002 

### Brief Summary

<!--
copilot:summary
-->
### <samp>🤖 Generated by Copilot at f2ee059</samp>

Improve kernel compilation manager efficiency by avoiding redundant
cache loading.
### Walkthrough

<!--
copilot:walkthrough
-->
### <samp>🤖 Generated by Copilot at f2ee059</samp>

* Add a check for existing kernel data to avoid redundant loading
([link](https://github.com/taichi-dev/taichi/pull/7741/files?diff=unified&w=0#diff-b7662dbf5bcf20f4b99048f4f2405316c0ba037c0722273522efaad72d256ef0L219-R228))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

@lin-hitonami lin-hitonami Awaiting requested review from lin-hitonami

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PGZXB @ailzhang