Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vulkan] Fix GGUI and vulkan swapchain on AMD drivers #7382

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Feb 16, 2023

Issue: #7291

This might also fix Intel. Can anyone with intel iGPU check for me?

@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 291d486
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63f7d02d2e2b3700086faf58

@PENGUINLIONG
Copy link
Member

@neozhaoliang could you check if the fix could break on your intel integrated graphics?

@neozhaoliang
Copy link
Contributor

neozhaoliang commented Feb 23, 2023

Looks great! This PR seems can fix the issue: #7338
However, the error in #6684 still occurs.

@PENGUINLIONG
Copy link
Member

@neozhaoliang That should be a separate issue. I'm approving since #7338 has been resolved.

@bobcao3 bobcao3 merged commit b1750f1 into taichi-dev:master Feb 23, 2023
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: taichi-dev#7291

This might also fix Intel. Can anyone with intel iGPU check for me?

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants