[lang] Stop broadcasting scalar cond in select statements #7344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
dream189free
changed the title
cond in select statements
jim19930609
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Good job! Btw you can add a C++ test to:
- create a TernaryOpExpression at Frontend IR level
- make a function call to TernaryOpExpression::type_check(...)
- Verify that the
condwasn't broadcast-ed anymore
you can refer to: tests/cpp/ir/frontend_type_inference_test.cpp
jim19930609
suggested changes
Feb 15, 2023
jim19930609
approved these changes
Feb 15, 2023
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
…#7344) Issue: taichi-dev#7240 ### Brief Summary 1. Stop broadcasting `cond` when it is a scalar in a `select` statement. 2. Since `config.real_matrix_scalarize` is currently set to `True`, we need to scalarize the `select`. I added another code path to do this, which seems ugly. 3. We can see the expected behavior when `config.real_matrix_scalarize` is unset. 4. Add python and c++ unit test for select stmts. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7240
Brief Summary
condwhen it is a scalar in aselectstatement.config.real_matrix_scalarizeis currently set toTrue, we need to scalarize theselect. I added another code path to do this, which seems ugly.config.real_matrix_scalarizeis unset.