Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhi] Update compute CommandList APIs (except dispatch) #7037

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Jan 4, 2023

Issue: #6832

Brief Summary

Compute-only CommandList APIs other than dispatch has been changed to use noexcept, and the behavior specifications has been added, and relevant checks are now in place for Vulkan and partially for DX11.

@bobcao3 bobcao3 requested review from PENGUINLIONG and k-ye January 4, 2023 01:46
@netlify
Copy link

netlify bot commented Jan 4, 2023

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 74ad7db
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63b5394dfb388b0008d672c0

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobcao3
Copy link
Collaborator Author

bobcao3 commented Jan 4, 2023

/rebase

@bobcao3 bobcao3 merged commit 21e5c91 into taichi-dev:master Jan 4, 2023
feisuzhu pushed a commit to feisuzhu/taichi that referenced this pull request Jan 5, 2023
)

Issue: taichi-dev#6832

### Brief Summary

Compute-only CommandList APIs other than dispatch has been changed to
use `noexcept`, and the behavior specifications has been added, and
relevant checks are now in place for Vulkan and partially for DX11.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
)

Issue: taichi-dev#6832

### Brief Summary

Compute-only CommandList APIs other than dispatch has been changed to
use `noexcept`, and the behavior specifications has been added, and
relevant checks are now in place for Vulkan and partially for DX11.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants