Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aot] C_API behavior test #6904

Merged
merged 45 commits into from
Dec 20, 2022
Merged

[aot] C_API behavior test #6904

merged 45 commits into from
Dec 20, 2022

Conversation

damnkk
Copy link
Contributor

@damnkk damnkk commented Dec 15, 2022

Issue: #

Brief Summary

Added run out of memory test case.

damnkk and others added 30 commits December 12, 2022 13:01
step

step

step

step

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

step

testtoDstEvent

testtoCopyMemoryDTD

testToCopyMemoryDTD1

testToDestroyAOTModule

testToGetComputeGraph

rm_enter

modify_modle_path
@netlify
Copy link

netlify bot commented Dec 15, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit f4758f0
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/63a15d46615ad400085f7c16

@PENGUINLIONG
Copy link
Member

There is an on-going rafactorization to add error codes to all RHI interfaces. We don't have it for now so I'm not sure if it's a proper way to report OOM errors for the release. Or we just wait for a future commit of OOM RHI error to be merged? wdyt @bobcao3 @ailzhang

@ailzhang
Copy link
Contributor

IMHO it doesn't have to be blocked by the missing OOM error code in rhi refactorization as long as we add a FIXME and fix it right after the merge. Adding these tests will also help make sure the refactorization goes well.

Copy link
Member

@PENGUINLIONG PENGUINLIONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm then. thank you!

@PENGUINLIONG PENGUINLIONG merged commit d2957d9 into taichi-dev:master Dec 20, 2022
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: #

### Brief Summary
Added run out of memory test case.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants