[Lang] Deprecate element_dim and element_shape in ndarray annotations. #6665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
…to deprecate_elem_shape
for more information, see https://pre-commit.ci
ailzhang
approved these changes
Nov 20, 2022
Co-authored-by: Ailing <ailzhang@users.noreply.github.com>
for more information, see https://pre-commit.ci
…o deprecate_elem_shape
quadpixels
pushed a commit
to quadpixels/taichi
that referenced
this pull request
May 13, 2023
taichi-dev#6665) Issue: taichi-dev#6572 Changes: * Add deprecation warning when `element_shape` and `element_dim` are specified. * Internally remove `element_shape` and `element_dim` inside the type annotation. Added a helper function to create respective MatrixType in dtype for legacy code. * Add deprecation test. * Update docstring. Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Ailing <ailzhang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6572
Changes:
element_shapeandelement_dimare specified.element_shapeandelement_diminside the type annotation. Added a helper function to create respective MatrixType in dtype for legacy code.