-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metal] Silence compile warning with [[maybe_unused]] #650
Conversation
Does requesting a review from @taichi-gardener (which is a robot) means a request to auto-format your code (which sounds like a great idea), or should I review it instead? |
The former :) I will ping you directly if i think a PR is worth a review... BTW, I found that clicking the format server sometimes didn't generate a reformat commit. Does that mean that there is no change after the server formats the PR? |
This sounds like a great feature to implement. Much better than the current format server approach.
Right, there's no way to commit without a changeset. |
I should probably clarify 😂 I added @taichi-gardener in the hope that it will do an automatic reformat for me on this PR. Not sure if this actually works... |
No, currently this won't work. But I think this is a great idea. Someone needs to implement this using github API. |
Hmm, guess this will be one of those "nuance differences" between my local |
Sounds good. Another option is to install |
I guess one of those clang-format options probably controls this behavior, but i'm too lazy to figure that out... Anyway, I've reformatted locally and disabled |
Related issue id = #593
[Click here for the format server]