Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] [bug] Fix setting integer arguments within u64 range but greater than i64 range #6267

Merged
merged 11 commits into from
Oct 11, 2022

Conversation

lin-hitonami
Copy link
Contributor

@lin-hitonami lin-hitonami commented Oct 10, 2022

Issue: fixes #6264

Brief Summary

@netlify
Copy link

netlify bot commented Oct 10, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 5dc0ce1
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/634510b7bb10d200083c3c57
😎 Deploy Preview https://deploy-preview-6267--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lin-hitonami
Copy link
Contributor Author

We may need to write separate functions to treat signed and unsigned integers because if the argument is uint64, the minus numbers are not accepted...

@lin-hitonami lin-hitonami marked this pull request as draft October 10, 2022 07:55
@lin-hitonami lin-hitonami marked this pull request as ready for review October 11, 2022 06:43
@lin-hitonami lin-hitonami requested review from jim19930609, ailzhang and strongoier and removed request for strongoier, ailzhang and jim19930609 October 11, 2022 09:24
@lin-hitonami lin-hitonami merged commit f97e48c into taichi-dev:master Oct 11, 2022
@lin-hitonami lin-hitonami deleted the fix-u64 branch October 11, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't pass in numbers >= 2^63 as ti.u64
2 participants