Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Remove redundant codegen of integer pow #6048

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

strongoier
Copy link
Contributor

@strongoier strongoier commented Sep 13, 2022

Related issue = #5915, #6134

As pow() with integer exponent is already demoted (#6044), there's no need for backends to handle integer pows.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

taichi/codegen/cuda/codegen_cuda.cpp Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit c1f1674
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/632085d090a3f50008732e74
😎 Deploy Preview https://deploy-preview-6048--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@AD1024 AD1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit c1fd7b2 into taichi-dev:master Sep 14, 2022
@strongoier strongoier deleted the remove-codegen-pow branch September 14, 2022 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants