Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertions to prevent infinite loop in least_pot_bound in case of negative snode size #567

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Add assertions to prevent infinite loop in least_pot_bound in case of negative snode size #567

merged 1 commit into from
Mar 6, 2020

Conversation

xumingkuan
Copy link
Contributor

Test case:

import taichi as ti
ti.root.dense(ti.i, -1)

yuanming-hu
yuanming-hu approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Will merge once CI passes (and the github authorship bug is fixed.) :-)

@yuanming-hu yuanming-hu merged commit 51bd159 into taichi-dev:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanming-hu yuanming-hu yuanming-hu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xumingkuan @yuanming-hu