Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autodiff] Check not placed field.grad when needs_grad = True #5295

Merged
merged 7 commits into from
Jul 1, 2022

Conversation

erizmr
Copy link
Contributor

@erizmr erizmr commented Jun 29, 2022

Related issue = #4015
Check the not placed grad fields when needs_grad=True at python runtime materialize stage.
Add the dtype checker for autodiff, raise error when unsupported dtype is passed.

@netlify
Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 646a12a
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62bec55cee08790008bdde05
😎 Deploy Preview https://deploy-preview-5295--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@erizmr erizmr changed the title [autodiff] Make FieldBuilder place field.grad if needs_grad = True [autodiff] Check not placed field.grad when needs_grad = True Jun 29, 2022
@erizmr erizmr requested a review from ailzhang June 30, 2022 08:03
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit 31f46dd into taichi-dev:master Jul 1, 2022
@erizmr erizmr deleted the fieldbuilder_grad branch July 1, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants