Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] Detailed error message when GGUI is not available #5164

Merged
merged 1 commit into from
Jun 16, 2022
Merged

[gui] Detailed error message when GGUI is not available #5164

merged 1 commit into from
Jun 16, 2022

Conversation

feisuzhu
Copy link
Contributor

Related issue = #5090

@feisuzhu feisuzhu requested a review from ailzhang June 14, 2022 08:22
@CLAassistant
Copy link

CLAassistant commented Jun 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jun 14, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 48eee8e
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62a9373c15edc1000863ebf7
😎 Deploy Preview https://deploy-preview-5164--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@feisuzhu feisuzhu force-pushed the fix/proper-error-msg-for-unsupported branch 2 times, most recently from 80710bf to 56dc9fa Compare June 14, 2022 09:49
@ailzhang ailzhang requested a review from qiao-bo June 14, 2022 09:50
ailzhang
ailzhang reviewed Jun 14, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

python/taichi/ui/utils.py Show resolved Hide resolved
python/taichi/ui/utils.py Outdated Show resolved Hide resolved
@feisuzhu feisuzhu force-pushed the fix/proper-error-msg-for-unsupported branch from f6c1140 to 7a20477 Compare June 14, 2022 10:13
ailzhang
ailzhang reviewed Jun 14, 2022
View reviewed changes
python/taichi/ui/utils.py Show resolved Hide resolved
python/taichi/ui/utils.py Outdated Show resolved Hide resolved
@feisuzhu feisuzhu force-pushed the fix/proper-error-msg-for-unsupported branch from ab6e943 to 404866b Compare June 14, 2022 10:38
@qiao-bo qiao-bo changed the title [ui] Detailed error message when GGUI is not available [gui] Detailed error message when GGUI is not available Jun 14, 2022
@qiao-bo
Copy link
Contributor

qiao-bo commented Jun 14, 2022

/rebase

@taichi-gardener taichi-gardener force-pushed the fix/proper-error-msg-for-unsupported branch from 404866b to 0d701c4 Compare June 14, 2022 12:24
@qiao-bo
Copy link
Contributor

qiao-bo commented Jun 14, 2022

PR title check fails at unrecognized tag, seems like we don't have ui tag. Change to gui and rebase to trigger the build. @feisuzhu btw, don't forget the CLA ;/

qiao-bo
qiao-bo approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!
Have a suggestion regarding to the exception messages: Maybe later we can add a FAQ in our website (docs.taichi.graphics) to describe the GGUI availability problem. And all these exceptions can be shortened and pointed to that link.

@feisuzhu feisuzhu force-pushed the fix/proper-error-msg-for-unsupported branch from 0d701c4 to 48eee8e Compare June 15, 2022 01:34
@feisuzhu
Copy link
Contributor Author

PR title check fails at unrecognized tag, seems like we don't have ui tag. Change to gui and rebase to trigger the build. @feisuzhu btw, don't forget the CLA ;/

done

ailzhang
ailzhang approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ailzhang ailzhang merged commit 3ec9118 into taichi-dev:master Jun 16, 2022
ailzhang pushed a commit to ailzhang/taichi that referenced this pull request Jun 17, 2022
@feisuzhu
[gui] Detailed error message when GGUI is not available (taichi-dev#5164
1e38b8e 
)
@feisuzhu feisuzhu deleted the fix/proper-error-msg-for-unsupported branch June 17, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiao-bo qiao-bo qiao-bo approved these changes

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@feisuzhu @CLAassistant @qiao-bo @ailzhang