Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cuda] Disable reduction in non-full warps #5161

Merged
merged 4 commits into from
Jun 14, 2022

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Jun 14, 2022

Fixes #5148
Fixes #5142

@netlify
Copy link

netlify bot commented Jun 14, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 460e04e
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62a8a6d37cd54e0008d1c56c
😎 Deploy Preview https://deploy-preview-5161--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we add the repro example in #5148 as a test to prevent future regression?

Copy link
Contributor

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobcao3 bobcao3 merged commit 485c9f1 into taichi-dev:master Jun 14, 2022
@bobcao3 bobcao3 deleted the bobcao3/fix-cuda branch June 14, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants