Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-threaded unit testing by pytest #483

Merged
merged 29 commits into from
Feb 17, 2020
Merged

Multi-threaded unit testing by pytest #483

merged 29 commits into from
Feb 17, 2020

Conversation

archibate
Copy link
Collaborator

Related issue id = #481

@archibate
Copy link
Collaborator Author

How... how to rebase?

@yuanming-hu
Copy link
Member

yuanming-hu commented Feb 16, 2020 •
edited
Loading

Since some commits (x ** y gradients) are still in #482 and hasn't been merged, let's merge that in first :-)

I guess an easier way is to create independent branches for each PR (forking from master), so that the commits are independent.

yuanming-hu
yuanming-hu reviewed Feb 16, 2020
View reviewed changes
python/taichi/main.py Outdated Show resolved Hide resolved
@archibate
Copy link
Collaborator Author

archibate commented Feb 16, 2020 •
edited
Loading

new for adf2f4f:
ti test pow and ti test_python pow are equivalent to ti test_python test_pow.py

@archibate
Copy link
Collaborator Author

-n 2 become ti arguments in travis.

@archibate
Copy link
Collaborator Author

appveyor does ti test too, doesn't it?

@yuanming-hu
Copy link
Member

@xumingkuan fixed ti.exe on Windows but for some unknown reason on AppVeyor ti still fails. So we are using python -m taichi test for now.

k-ye
k-ye reviewed Feb 17, 2020
View reviewed changes
python/taichi/main.py Outdated Show resolved Hide resolved
@archibate
Copy link
Collaborator Author

@xumingkuan fixed ti.exe on Windows but for some unknown reason on AppVeyor ti still fails. So we are using python -m taichi test for now.

So after we merged with master, this could be solved, right?

@archibate archibate mentioned this pull request Feb 17, 2020
Merged
@archibate
Copy link
Collaborator Author

Solved, the reason was pytest-xdist not installed in CI.

@yuanming-hu
Copy link
Member

So after we merged with master, this could be solved, right?

It should be solved. However, after adding %TAICHI_REPO_DIR%\bin (where ti.exe resides) to PATH, ti test still doesn't work in AppVeyor. Haven't got a chance to look into it.

Merging this PR in now...

@archibate
Copy link
Collaborator Author

archibate commented Feb 17, 2020 •
edited
Loading

Also, you want to install pytest-xdist in CI. Currently, I made -n option automatically detected, because it fails if xdist not installed.

@yuanming-hu yuanming-hu merged commit a5d6e04 into taichi-dev:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-ye k-ye k-ye left review comments

@yuanming-hu yuanming-hu yuanming-hu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@archibate @yuanming-hu @k-ye