Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] Add mod function to math module #4809

Merged
merged 1 commit into from
Apr 18, 2022
Merged

[Lang] Add mod function to math module #4809

merged 1 commit into from
Apr 18, 2022

Conversation

neozhaoliang
Copy link
Contributor

@neozhaoliang neozhaoliang commented Apr 18, 2022 •
edited
Loading

This PR add mod function to the math module.

@netlify
Copy link

netlify bot commented Apr 18, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit be74254
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/625cb408f76aed00096d5bbc
😎 Deploy Preview https://deploy-preview-4809--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rexwangcc
rexwangcc approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@rexwangcc rexwangcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

strongoier
strongoier reviewed Apr 18, 2022
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between the new mod and the original %?

@TiGeekMan
Copy link
Contributor

@strongoier mod always returns a float vector, even for int inputs. I add this function since it would be more familiar for glsl users.

@strongoier strongoier merged commit 4512ccc into taichi-dev:master Apr 18, 2022
k-ye pushed a commit to k-ye/taichi that referenced this pull request May 5, 2022
@neozhaoliang @k-ye
[Lang] Add mod function to math module (taichi-dev#4809)
8ff50ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongoier strongoier strongoier left review comments

@rexwangcc rexwangcc rexwangcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neozhaoliang @TiGeekMan @strongoier @rexwangcc