-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[misc] Update pre-commit hooks #4713
Conversation
updates: - [github.com/google/yapf: v0.31.0 → v0.32.0](google/yapf@v0.31.0...v0.32.0) - https://github.com/timothycrosley/isort → https://github.com/PyCQA/isort - [github.com/pre-commit/mirrors-clang-format: v10.0.1 → v13.0.1](pre-commit/mirrors-clang-format@v10.0.1...v13.0.1) - [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0) - [github.com/PyCQA/pylint: v2.13.1 → v2.13.4](pylint-dev/pylint@v2.13.1...v2.13.4)
✅ Deploy Preview for docsite-preview canceled.
|
de1ce88
to
931e54c
Compare
@qiao-bo I've added a rule for yapf, now the linter status turns green. It seems clang-format 12+ also removed a space in between |
Thanks for the quick fix. About the added space: Is it possible to enforce this rule in our |
This is a change in clang-format 11 and unfortunately, it doesn't expose a config for this. BTW, in fact, the new behavior is to remove the space, not add. |
ok, then let's just accept this. |
@frostming Is there a way to pin the yapf and clang-format version in pre-commit-bot instead?:P |
@ailzhang I am afraid not, the PR will be sent each quarter. I have filed an FR to pre-commit/pre-commit#2331 |
once per quarter should be fine. @ailzhang let's merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/google/yapf: v0.31.0 → v0.32.0](google/yapf@v0.31.0...v0.32.0) - https://github.com/timothycrosley/isort → https://github.com/PyCQA/isort - [github.com/pre-commit/mirrors-clang-format: v10.0.1 → v13.0.1](pre-commit/mirrors-clang-format@v10.0.1...v13.0.1) - [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0) - [github.com/PyCQA/pylint: v2.13.1 → v2.13.4](pylint-dev/pylint@v2.13.1...v2.13.4) * Add style config for yapf 0.32 * Change the commit message to follow taichi's rule Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Frost Ming <mianghong@gmail.com> Co-authored-by: Ailing <ailzhang@users.noreply.github.com>
updates: