Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] Update pre-commit hooks #4713

Merged
merged 4 commits into from
Apr 22, 2022
Merged

[misc] Update pre-commit hooks #4713

merged 4 commits into from
Apr 22, 2022

Conversation

updates:
- [github.com/google/yapf: v0.31.0 → v0.32.0](google/yapf@v0.31.0...v0.32.0)
- https://github.com/timothycrosley/isorthttps://github.com/PyCQA/isort
- [github.com/pre-commit/mirrors-clang-format: v10.0.1 → v13.0.1](pre-commit/mirrors-clang-format@v10.0.1...v13.0.1)
- [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0)
- [github.com/PyCQA/pylint: v2.13.1 → v2.13.4](pylint-dev/pylint@v2.13.1...v2.13.4)
@netlify
Copy link

netlify bot commented Apr 4, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit e22ebc2
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6262334003a382000941c519

@qiao-bo qiao-bo requested a review from frostming April 5, 2022 04:07
@frostming frostming self-assigned this Apr 5, 2022
@frostming frostming force-pushed the pre-commit-ci-update-config branch from de1ce88 to 931e54c Compare April 5, 2022 14:39
@frostming frostming changed the title [pre-commit.ci] pre-commit autoupdate [misc] pre-commit autoupdate Apr 5, 2022
@frostming
Copy link
Collaborator

frostming commented Apr 5, 2022

@qiao-bo I've added a rule for yapf, now the linter status turns green. It seems clang-format 12+ also removed a space in between &&... args, can we just accept and follow it?

@frostming frostming changed the title [misc] pre-commit autoupdate [misc] Update pre-commit hooks Apr 5, 2022
@qiao-bo
Copy link
Contributor

qiao-bo commented Apr 6, 2022

@qiao-bo I've added a rule for yapf, now the linter status turns green. It seems clang-format 12+ also added a space in between &&... args, can we just accept and follow it?

Thanks for the quick fix. About the added space: Is it possible to enforce this rule in our .clang-format file? (did we even use this config file? ;/) Many of us are still using clang 10 toolings and better to be consistent across commits.

@frostming
Copy link
Collaborator

frostming commented Apr 6, 2022

This is a change in clang-format 11 and unfortunately, it doesn't expose a config for this.

Reference: https://stackoverflow.com/questions/65964384/how-to-make-clang-format-11-put-a-space-after-variadic-template-decleration

BTW, in fact, the new behavior is to remove the space, not add.

@qiao-bo
Copy link
Contributor

qiao-bo commented Apr 6, 2022

This is a change in clang-format 11 and unfortunately, it doesn't expose a config for this.

Reference: https://stackoverflow.com/questions/65964384/how-to-make-clang-format-11-put-a-space-after-variadic-template-decleration

BTW, in fact, the new behavior is to remove the space, not add.

ok, then let's just accept this.

@ailzhang
Copy link
Contributor

ailzhang commented Apr 6, 2022

@frostming Is there a way to pin the yapf and clang-format version in pre-commit-bot instead?:P

@frostming
Copy link
Collaborator

frostming commented Apr 6, 2022

@ailzhang I am afraid not, the PR will be sent each quarter. I have filed an FR to pre-commit/pre-commit#2331

@qiao-bo
Copy link
Contributor

qiao-bo commented Apr 6, 2022

once per quarter should be fine. @ailzhang let's merge this?

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit 0185aa0 into master Apr 22, 2022
@frostming frostming deleted the pre-commit-ci-update-config branch April 22, 2022 07:28
k-ye pushed a commit to k-ye/taichi that referenced this pull request May 5, 2022
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/google/yapf: v0.31.0 → v0.32.0](google/yapf@v0.31.0...v0.32.0)
- https://github.com/timothycrosley/isorthttps://github.com/PyCQA/isort
- [github.com/pre-commit/mirrors-clang-format: v10.0.1 → v13.0.1](pre-commit/mirrors-clang-format@v10.0.1...v13.0.1)
- [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0)
- [github.com/PyCQA/pylint: v2.13.1 → v2.13.4](pylint-dev/pylint@v2.13.1...v2.13.4)

* Add style config for yapf 0.32

* Change the commit message to follow taichi's rule

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Frost Ming <mianghong@gmail.com>
Co-authored-by: Ailing <ailzhang@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants