[IR] Init GlobalTensorElementExpression and PtrOffsetStmt #2543

squarefk · 2021-07-19T09:17:07Z

Related Issue = #2590

Below is the design overview and some concerns to resolve before moving on to accomplish all related components like type-check, ir-printer...

From Python AST, it generates GlobalTensorElementExpression(GlobalPtrExpression, Expr).
In lower_ast pass, it will be lowered into GlobalTensorElementStmt(GlobalPtrStmt, Stmt)
In lower_access pass, the lower process of GlobalPtrStmt has been moved into visit(GlobalTensorElementStmt*)
With codegen_llvm, GlobalTensorElementStmt will emit function calls (acces_with_offset_*) predefined in llvm/runtime.cpp

Concerns:

Line 1. shall we have GlobalTensorElementExpression inherited from GlobalPtrExpression or directly from Expression?
Line 3. why do we not have something like visit(GlobalPtrStmt*)?
Line 4. is there any better solution?

taichi/ir/statements.h

k-ye · 2021-07-19T12:43:05Z

From Python AST, it generates GlobalTensorElementExpression(GlobalPtrExpression, Expr).

I think it should be (GlobalPtrExpression, ExprGroup)? Otherwise we cannot support dynamic indexing for a ti.Matrix?

CLAassistant · 2021-07-20T06:13:04Z

All committers have signed the CLA.

squarefk · 2021-07-21T07:34:20Z

/format

…sorElementStmt

k-ye

Awesome work! A few code style suggestions

taichi/ir/expr.cpp

python/taichi/lang/matrix.py

taichi/ir/frontend_ir.cpp

taichi/ir/frontend_ir.h

taichi/ir/statements.h

taichi/ir/frontend_ir.h

taichi/transforms/lower_access.cpp

taichi/ir/expr.cpp

Co-authored-by: xumingkuan <xumingkuan0721@126.com>

squarefk · 2021-07-27T02:14:46Z

/format

strongoier

Maybe we can rename GlobalTensorElementStmt to something like GlobalPtrWithOffsetStmt?

tests/python/test_matrix.py

python/taichi/lang/matrix.py

tests/python/test_matrix.py

taichi/ir/statements.h

taichi/transforms/type_check.cpp

strongoier

LGTM!

strongoier · 2021-07-29T08:50:24Z

/format

squarefk · 2021-07-29T08:59:50Z

/format

squarefk · 2021-07-29T09:23:33Z

/format

xumingkuan

I believe alias_analysis.cpp should be modified. Currently any two ShiftGlobalPtrStmts will result in AliasResult::uncertain, which is too conservative. (Feel free to use value_diff_ptr_index or same_value to implement alias_analysis)

taichi/ir/statements.h

k-ye

Great work!

taichi/codegen/codegen_llvm.cpp

taichi/ir/statements.h

squarefk · 2021-07-30T07:26:40Z

/format

squarefk · 2021-07-30T07:28:07Z

I believe alias_analysis.cpp should be modified. Currently any two ShiftGlobalPtrStmts will result in AliasResult::uncertain, which is too conservative. (Feel free to use value_diff_ptr_index or same_value to implement alias_analysis)

I believe you are right. I will open another pull request about this after I get more familiar with CFG optimization passes.

init GlobalTensorElementExpression and GlobalTensorElementExpr

25227b0

ljcc0930 changed the title ~~[IR] init GlobalTensorElementExpression and GlobalTensorElementExpr~~ [IR] Init GlobalTensorElementExpression and GlobalTensorElementExpr Jul 19, 2021

squarefk added 3 commits July 19, 2021 17:57

fix compile error for global load

b0e3b11

fix cfg optimization

a9d3dc2

fix offset=4 for i32 and f32

5aaf917

xumingkuan reviewed Jul 19, 2021

View reviewed changes

taichi/ir/statements.h Show resolved Hide resolved

xumingkuan mentioned this pull request Jul 19, 2021

[IR] Unify global pointers #2546

Open

support matrix indices access, AOS SOA, and arbitrary date type

1e2ab62

taichi-gardener and others added 8 commits July 21, 2021 07:35

Auto Format

cbc7950

do better serialize() for GlobalTensorElementExpression and GlobalTen…

7684a3f

…sorElementStmt

simplify make<ConstStmt>

fbd0f1a

fix ti test

1120afb

fix test and add load_if_ptr for dynamic indices

11d89e0

fix test

2705249

fix more tests

587569b

fix more tests

b009a94

k-ye reviewed Jul 23, 2021

View reviewed changes

k-ye requested a review from strongoier July 23, 2021 12:01

squarefk added 9 commits July 26, 2021 11:57

fix test

4d68187

fix test

e445596

update test

cc6317d

merge condition in load_if_ptr

9d3ecb1

replace is_AOS with is_aos

46dd8a2

remove is_bit_vectorized

6922a51

add default value for GlobalTensorElementStmt

d059195

add default value for GlobalTensorElementExpression

e3cc893

Merge branch 'master' of https://github.com/taichi-dev/taichi

915941e

xumingkuan reviewed Jul 26, 2021

View reviewed changes

taichi/ir/expr.cpp Outdated Show resolved Hide resolved

squarefk and others added 3 commits July 27, 2021 10:04

Update taichi/ir/expr.cpp

99e4a18

Co-authored-by: xumingkuan <xumingkuan0721@126.com>

comment is_global_ptr()

a68187f

nit

1123d63

taichi-gardener and others added 2 commits July 27, 2021 02:15

Auto Format

da3c394

Merge branch 'master' of https://github.com/taichi-dev/taichi

9985bac

strongoier suggested changes Jul 28, 2021

View reviewed changes

add extension and fix tests

848db37

squarefk force-pushed the master branch from 73ec3f0 to 848db37 Compare July 29, 2021 08:40

strongoier approved these changes Jul 29, 2021

View reviewed changes

Auto Format

6a43da7

squarefk changed the title ~~[IR] Init GlobalTensorElementExpression and GlobalTensorElementExpr~~ [IR] Init GlobalTensorElementExpression and ShiftGlobalPtrStmt Jul 29, 2021

squarefk added 2 commits July 29, 2021 17:13

do actual type check

e37ed47

rename GlobalTensorElementStmt into ShiftGlobalPtrStmt

6c2ea50

Auto Format

cccd882

xumingkuan reviewed Jul 29, 2021

View reviewed changes

taichi/ir/statements.h Show resolved Hide resolved

k-ye approved these changes Jul 29, 2021

View reviewed changes

taichi/codegen/codegen_llvm.cpp Outdated Show resolved Hide resolved

taichi/ir/statements.h Show resolved Hide resolved

squarefk added 2 commits July 30, 2021 15:20

nit address_offset

d9bdf42

rename ShiftGlobalPtrStmt into PtrOffsetStmt

3c20d48

Auto Format

3da4b3e

squarefk changed the title ~~[IR] Init GlobalTensorElementExpression and ShiftGlobalPtrStmt~~ [IR] Init GlobalTensorElementExpression and PtrOffsetStmt Jul 30, 2021

k-ye merged commit e71f2eb into taichi-dev:master Jul 31, 2021

Leonz5288 mentioned this pull request Aug 3, 2021

[release] v0.7.28 #2631

Merged

strongoier mentioned this pull request Dec 8, 2021

Support dynamic indexing in ti.Vector/ti.Matrix #2590

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IR] Init GlobalTensorElementExpression and PtrOffsetStmt #2543

[IR] Init GlobalTensorElementExpression and PtrOffsetStmt #2543

squarefk commented Jul 19, 2021 •

edited by k-ye

Loading

k-ye commented Jul 19, 2021

CLAassistant commented Jul 20, 2021 •

edited

Loading

squarefk commented Jul 21, 2021

k-ye left a comment

squarefk commented Jul 27, 2021

strongoier left a comment

strongoier left a comment

strongoier commented Jul 29, 2021

squarefk commented Jul 29, 2021

squarefk commented Jul 29, 2021

xumingkuan left a comment •

edited

Loading

k-ye left a comment

squarefk commented Jul 30, 2021

squarefk commented Jul 30, 2021

[IR] Init GlobalTensorElementExpression and PtrOffsetStmt #2543

[IR] Init GlobalTensorElementExpression and PtrOffsetStmt #2543

Conversation

squarefk commented Jul 19, 2021 • edited by k-ye Loading

k-ye commented Jul 19, 2021

CLAassistant commented Jul 20, 2021 • edited Loading

squarefk commented Jul 21, 2021

k-ye left a comment

Choose a reason for hiding this comment

squarefk commented Jul 27, 2021

strongoier left a comment

Choose a reason for hiding this comment

strongoier left a comment

Choose a reason for hiding this comment

strongoier commented Jul 29, 2021

squarefk commented Jul 29, 2021

squarefk commented Jul 29, 2021

xumingkuan left a comment • edited Loading

Choose a reason for hiding this comment

k-ye left a comment

Choose a reason for hiding this comment

squarefk commented Jul 30, 2021

squarefk commented Jul 30, 2021

squarefk commented Jul 19, 2021 •

edited by k-ye

Loading

CLAassistant commented Jul 20, 2021 •

edited

Loading

xumingkuan left a comment •

edited

Loading