[async] [bug] Fix missing memory access options in async mode #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
LGTM! Thanks.
Off-topic: I'm not sure if two struct-fors with different index offsets can be fused together.
After searching through the current code, it seems to me that index_offsets are only used in lower_ast and offload, so it should be OK to ignore them in fusion.
|
IIUC coordinate offsets can be completely implemented in Python side to reduce maintainance cost? |
xumingkuan
commented
Jan 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #742
Fixes
OffloadedStmt::clone(), and mergesOffloadedStmt::mem_access_opts when fusing.Off-topic: I'm not sure if two struct-fors with different index offsets can be fused together.
[Click here for the format server]