Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Error] [ipython] Use print directly instead of builtin warnings module to prevent being supressed #1969

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

archibate
Copy link
Collaborator

Related issue = #677 (comment)

[Click here for the format server]


It seems that if I use IPython (ti repl), the warning is depressed. If I use raw Python shell (python), the warning is shown.
So IPython is setting warnings.filterwarnings('ignore') on their own? Anyway, the built-in warning system seems unreliable.
Let's switch to standard print for warning instead.

@archibate archibate requested a review from yuanming-hu October 17, 2020 05:44
@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #1969 into master will increase coverage by 0.07%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1969      +/-   ##
==========================================
+ Coverage   43.64%   43.72%   +0.07%     
==========================================
  Files          45       45              
  Lines        6225     6221       -4     
  Branches     1106     1105       -1     
==========================================
+ Hits         2717     2720       +3     
+ Misses       3334     3328       -6     
+ Partials      174      173       -1     
Impacted Files Coverage Δ
python/taichi/lang/meta.py 64.00% <0.00%> (+1.17%) ⬆️
python/taichi/misc/util.py 20.54% <100.00%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c1edb7...c9b4b8f. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't exactly know what happened with IPython, but it works on my end.

@yuanming-hu yuanming-hu merged commit 68ec8d9 into taichi-dev:master Oct 17, 2020
@yuanming-hu yuanming-hu mentioned this pull request Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants