Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[type] Remove DataType::width #1962

Merged
merged 6 commits into from
Oct 16, 2020
Merged

[type] Remove DataType::width #1962

merged 6 commits into from
Oct 16, 2020

Conversation

yuanming-hu
Copy link
Member

@yuanming-hu yuanming-hu commented Oct 16, 2020 •
edited
Loading

Related issue = #1905

  • Removed DataType::width
  • Stmt::width() is no longer writable
  • Added Type::vector_width()

[Click here for the format server]

@yuanming-hu yuanming-hu requested a review from Hanke98 October 16, 2020 04:51
Hanke98
Hanke98 reviewed Oct 16, 2020
View reviewed changes
Copy link
Contributor

@Hanke98 Hanke98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Most changes LGTM! I only have one question here:

taichi/transforms/offload.cpp Show resolved Hide resolved
@Hanke98 Hanke98 self-requested a review October 16, 2020 15:19
Hanke98
Hanke98 approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@Hanke98 Hanke98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! LGTM!

@yuanming-hu yuanming-hu merged commit 6cbe537 into taichi-dev:master Oct 16, 2020
This was referenced Oct 16, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hanke98 Hanke98 Hanke98 approved these changes

@taichi-gardener taichi-gardener Awaiting requested review from taichi-gardener

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuanming-hu @Hanke98 @taichi-gardener