Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[type] Initial TypeFactory class #1942

Merged
merged 3 commits into from
Oct 12, 2020
Merged

[type] Initial TypeFactory class #1942

merged 3 commits into from
Oct 12, 2020

Conversation

yuanming-hu
Copy link
Member

@codecov
Copy link

codecov bot commented Oct 12, 2020 •
edited
Loading

Codecov Report

Merging #1942 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1942   +/-   ##
=======================================
  Coverage   43.72%   43.72%           
=======================================
  Files          45       45           
  Lines        6207     6207           
  Branches     1103     1103           
=======================================
  Hits         2714     2714           
  Misses       3322     3322           
  Partials      171      171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db9ceeb...4dc5447. Read the comment docs.

TH3CHARLie
TH3CHARLie approved these changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@TH3CHARLie TH3CHARLie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice start!

@TH3CHARLie TH3CHARLie merged commit e33d6ed into taichi-dev:master Oct 12, 2020
@yuanming-hu yuanming-hu deleted the type-factory branch October 12, 2020 13:57
@yuanming-hu yuanming-hu mentioned this pull request Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TH3CHARLie TH3CHARLie TH3CHARLie approved these changes

@taichi-gardener taichi-gardener Awaiting requested review from taichi-gardener

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuanming-hu @TH3CHARLie