[doc] Guard values with "ti.approx" in "docs/write_test.rst" to allow FP-error tolerance #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 彭于斌 <1931127624@qq.com>
…= ti.atan2(r[None], s[None])" in "docs/write_test.rst"
…= ti.atan2(r[None])" in "docs/write_test.rst"
…te_test.rst" to make sure the test case scripts pass the assert sentence.
archibate
requested review from
yuanming-hu,
rexwangcc and
archibate
and removed request for
yuanming-hu
rexwangcc
approved these changes
Oct 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #1911 +/- ##
=======================================
Coverage 43.86% 43.86%
=======================================
Files 45 45
Lines 6199 6199
Branches 1101 1101
=======================================
Hits 2719 2719
Misses 3311 3311
Partials 169 169 Continue to review full report at Codecov.
|
archibate
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the test cases in
docs/write_test.rstwill reports an assertion exception error due to the insignificant numerical error betweenti.atan2(y, x)andmath.atan2(y, x), theti.approx(r[None])will help these test cases pass these tests.