[gui] [ipython] Add GUI.__del__ to close on variable dereference #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1869 +/- ##
==========================================
+ Coverage 44.21% 44.29% +0.08%
==========================================
Files 44 44
Lines 6111 6113 +2
Branches 1092 1092
==========================================
+ Hits 2702 2708 +6
+ Misses 3240 3236 -4
Partials 169 169
Continue to review full report at Codecov.
|
archibate
commented
Sep 14, 2020
JYLeeLYJ
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
These code looks great to me.
More optional:
It's better to simply test on windows and Jupyter to confirm here is no any other things changes.
Would u mind me delaying these tests for a few days ? Cause I 'm staying outside these days and without related environment : )
…nto gui-del-close
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #
[Click here for the format server]
Otherwise window doesn't get closed after the script execution in sth like Jupyter or Blender (TODO: confirm if this work)