Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[async] [benchmark] Enable optimization for global variables after fusion #1776

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

xumingkuan
Copy link
Contributor

@xumingkuan xumingkuan commented Aug 25, 2020

Related issue = #742

after_lower_access=false allows cfg_optimization to optimize for global variables.

Also removes evaluators and accessors from #kernel_launches in the statistics.

Also adds ti.sync() after each run when benchmarking, and adjust the repeat parameters in async_cases accordingly.

benchmark20200825

[Click here for the format server]


@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #1776 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1776   +/-   ##
=======================================
  Coverage   42.66%   42.66%           
=======================================
  Files          44       44           
  Lines        6165     6165           
  Branches     1074     1074           
=======================================
  Hits         2630     2630           
  Misses       3380     3380           
  Partials      155      155           
Impacted Files Coverage Δ
python/taichi/lang/__init__.py 42.44% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca8545...bcca495. Read the comment docs.

@xumingkuan xumingkuan changed the title [async] Enable optimization for global variables after fusion [async] [benchmark] Enable optimization for global variables after fusion Aug 25, 2020
@xumingkuan xumingkuan requested a review from yuanming-hu August 25, 2020 11:17
Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM.

@yuanming-hu yuanming-hu merged commit ebcefbf into taichi-dev:master Aug 25, 2020
@yuanming-hu yuanming-hu mentioned this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants