[Example] Enhance stable_fluid.py with BFECC, RK2, RK3 and Taichi's new syntax #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archibate
commented
Jul 31, 2020
|
|
||
|
|
||
| @ti.kernel | ||
| def pressure_jacobi(pf: ti.template(), new_pf: ti.template()): | ||
| ti.cache_read_only(pf) |
There was a problem hiding this comment.
Btw, can we document this feature somewhere? I'm puzzled, despite it brings a bit of FPS improvements, and I guess I'm using it correct...
archibate
commented
Jul 31, 2020
| taichi_lang_core.cache(1, v.ptr) | ||
| def cache_read_only(*args): | ||
| for v in args: | ||
| taichi_lang_core.cache(1, v.loop_range().ptr) | ||
|
|
||
|
|
||
| def assume_in_range(val, base, low, high): |
There was a problem hiding this comment.
What is this function used for? Can we have a section performance.rst in Advanced programming explaining these cool APIs? Or they're just incomplete or even buggy for now?
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
==========================================
- Coverage 46.01% 44.20% -1.81%
==========================================
Files 40 41 +1
Lines 5544 5843 +299
Branches 1002 1011 +9
==========================================
+ Hits 2551 2583 +32
- Misses 2840 3106 +266
- Partials 153 154 +1
Continue to review full report at Codecov.
|
k-ye
approved these changes
Aug 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #
[Click here for the format server]
Btw, who wrote this cool example?