-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[async] Demote struct-fors in async compilation #1593
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1593 +/- ##
==========================================
+ Coverage 67.47% 67.58% +0.11%
==========================================
Files 40 40
Lines 5624 5634 +10
Branches 982 983 +1
==========================================
+ Hits 3795 3808 +13
+ Misses 1661 1657 -4
- Partials 168 169 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! Everything here looks great to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
compile_to_offloads()
into two functions:compile_to_offloads()
andcompile_to_executable()
. The former stops right before struct-for demotion. This allows me to run async mpm99 without any patches now.struct-for
to arange-for
, we need to callirpass::fix_root_block_kernel()
to fix the block kernels.Related issue = #1541
[Click here for the format server]