Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[async] Demote struct-fors in async compilation #1593

Merged
merged 5 commits into from
Jul 27, 2020

Conversation

k-ye
Copy link
Member

@k-ye k-ye commented Jul 25, 2020

  1. I separated compile_to_offloads() into two functions: compile_to_offloads() and compile_to_executable(). The former stops right before struct-for demotion. This allows me to run async mpm99 without any patches now.
  2. Note that after converting a struct-for to a range-for, we need to call irpass::fix_root_block_kernel() to fix the block kernels.

Related issue = #1541

[Click here for the format server]


@k-ye k-ye changed the title [async] Demote struct fors in async compilation [async] Demote struct-fors in async compilation Jul 25, 2020
@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #1593 into master will increase coverage by 0.11%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1593      +/-   ##
==========================================
+ Coverage   67.47%   67.58%   +0.11%     
==========================================
  Files          40       40              
  Lines        5624     5634      +10     
  Branches      982      983       +1     
==========================================
+ Hits         3795     3808      +13     
+ Misses       1661     1657       -4     
- Partials      168      169       +1     
Impacted Files Coverage Δ
python/taichi/main.py 42.35% <0.00%> (ø)
python/taichi/lang/shell.py 51.38% <47.45%> (+12.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4ce50...dbb6d87. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Everything here looks great to me.

Copy link
Collaborator

@archibate archibate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@archibate archibate merged commit bfd39e3 into taichi-dev:master Jul 27, 2020
@k-ye k-ye deleted the sep-offload branch July 27, 2020 11:14
@FantasyVR FantasyVR mentioned this pull request Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants