-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Example] Add comet.py and fix to_numpy() on sparse matrix fields #1583
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1583 +/- ##
==========================================
+ Coverage 67.47% 67.52% +0.04%
==========================================
Files 40 40
Lines 5624 5632 +8
Branches 982 982
==========================================
+ Hits 3795 3803 +8
Misses 1661 1661
Partials 168 168
Continue to review full report at Codecov.
|
ti.no_activate(x) | ||
for i in x: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we automatically use ti.no_activate(x)
when:
- the following struct-for is on
x
. - within that struct-for, only
x[i]
is written.
e.g.:
for i in x:
x[i] = 1 # OK to optimize
x[i // 2] = 1 # won't optimize
Thoughts? @xumingkuan @yuanming-hu
Merging now given that this is a trivial change. |
Related issue = #
[Click here for the format server]
Have you seen the NEOWISE comet yet 😆