Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example] Add comet.py and fix to_numpy() on sparse matrix fields #1583

Merged
merged 7 commits into from
Jul 31, 2020

Conversation

archibate
Copy link
Collaborator

@archibate archibate commented Jul 25, 2020

Related issue = #

[Click here for the format server]


video
Have you seen the NEOWISE comet yet 😆

@codecov
Copy link

codecov bot commented Jul 26, 2020

Codecov Report

Merging #1583 into master will increase coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1583      +/-   ##
==========================================
+ Coverage   67.47%   67.52%   +0.04%     
==========================================
  Files          40       40              
  Lines        5624     5632       +8     
  Branches      982      982              
==========================================
+ Hits         3795     3803       +8     
  Misses       1661     1661              
  Partials      168      168              
Impacted Files Coverage Δ
python/taichi/lang/matrix.py 91.90% <66.66%> (-0.13%) ⬇️
python/taichi/lang/__init__.py 80.20% <100.00%> (-0.01%) ⬇️
python/taichi/lang/ops.py 93.33% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4ce50...88808b9. Read the comment docs.

Comment on lines +29 to +30
ti.no_activate(x)
for i in x:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we automatically use ti.no_activate(x) when:

  1. the following struct-for is on x.
  2. within that struct-for, only x[i] is written.

e.g.:

for i in x:
  x[i] = 1  # OK to optimize
  x[i // 2] = 1  # won't optimize

Thoughts? @xumingkuan @yuanming-hu

@archibate
Copy link
Collaborator Author

Merging now given that this is a trivial change.

@archibate archibate merged commit 94eb0c9 into taichi-dev:master Jul 31, 2020
taichi-gardener added a commit that referenced this pull request Aug 1, 2020
@FantasyVR FantasyVR mentioned this pull request Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants