[llvm] Fix LLVM runtime sparse computation issues #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanming-hu
force-pushed
the
fix-sparsity
branch
from
70f1a91 to
04c69de
Compare
Codecov Report
@@ Coverage Diff @@
## master #1582 +/- ##
=======================================
Coverage 67.53% 67.53%
=======================================
Files 40 40
Lines 5630 5630
Branches 982 982
=======================================
Hits 3802 3802
Misses 1660 1660
Partials 168 168 Continue to review full report at Codecov.
|
yuanming-hu
commented
Jul 25, 2020
Comment on lines
-1328
to
+1339
| free_list->clear(); | ||
|
|
||
| const i32 num_unused = | ||
| max_i32(free_list->size() - allocator->free_list_used, 0); | ||
| free_list->resize(num_unused); | ||
|
|
There was a problem hiding this comment.
This fixes a serious memory leakage...
| @@ -29,7 +29,9 @@ void convert_to_range_for(OffloadedStmt *offloaded) { | |||
|
|
|||
| ////// Begin core transformation | |||
| auto body = std::move(offloaded->body); | |||
| const int num_loop_vars = snodes.back()->num_active_indices; | |||
| const int num_loop_vars = | |||
| snodes.empty() ? 0 : snodes.back()->num_active_indices; | |||
There was a problem hiding this comment.
Sometimes people may do some crazy thing like
for I in ti.grouped(ti.root):
...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Click here for the format server]