-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Replace tensor by field for files beginning with t to z #1579
[Doc] Replace tensor by field for files beginning with t to z #1579
Conversation
tensor
by field
for files beginning with t to z
tensor
by field
for files beginning with t to z
Hi @archibate ! So I have mostly updated all tensors to fields in our documents. And the changes are broken into 3 seperate PRs: 1577, 1578, 1579. Would you please give me some suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've a name nit.
Fields and matrices | ||
=================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fields and matrices | |
=================== | |
Matrix fields | |
============= |
The same to Vector fields
, it should sounds more than intuitive for STEM students, WDYT? @yuanming-hu @Rullec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good idea. But I guess the main task of this PR is simply do replacement, and make sure the replacements have no error.
I would personally prefer to refine the whole documents, make them more fluent and accurate in another PR, HDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thank for the reminder, let's do matrix fields
iapr.
Fields of scalars | ||
----------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fields of scalars | |
----------------- | |
Scalar fields | |
------------- |
|
||
- Global ``scalars`` are treated as 0-D tensors of scalars. | ||
- Global ``scalars`` are treated as 0-D fields of scalars. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Global ``scalars`` are treated as 0-D fields of scalars. | |
- Global ``scalars`` are treated as 0-D scalar fields. |
Please update the following changes too, I don't have time to comment them one-by-one.
Codecov Report
@@ Coverage Diff @@
## rullec-field #1579 +/- ##
=============================================
Coverage 67.45% 67.45%
=============================================
Files 40 40
Lines 5626 5626
Branches 981 981
=============================================
Hits 3795 3795
Misses 1662 1662
Partials 169 169 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. (don't forget to matrix field
iapr :)
Related issue = #1500
This PR tries to replace
tensor
byfeld
for files beginning witht
toz
[Click here for the format server]