-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Update mpm_lagrangian_force and fix Matrix constructor #1545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
So we don't have a test on this? |
Codecov Report
@@ Coverage Diff @@
## master #1545 +/- ##
==========================================
+ Coverage 86.10% 86.79% +0.69%
==========================================
Files 19 19
Lines 3548 3681 +133
Branches 631 652 +21
==========================================
+ Hits 3055 3195 +140
+ Misses 365 353 -12
- Partials 128 133 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thanks!
#1531 broke the example because it forgot to initialize
self.grad
. Adding the fix as well as updatingmpm_lagrangian_force.py
to usefield
.Related issue = #1531
[Click here for the format server]