[bug] Fix dynamic SNode activation #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumingkuan
approved these changes
Jul 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #1526 +/- ##
==========================================
- Coverage 67.63% 66.17% -1.46%
==========================================
Files 38 38
Lines 5567 5405 -162
Branches 973 976 +3
==========================================
- Hits 3765 3577 -188
- Misses 1635 1660 +25
- Partials 167 168 +1
Continue to review full report at Codecov.
|
|
I noticed that Travis CI failed due to test_dynamic.py::test_append_ret_value: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = close #1506
[Click here for the format server]
The old implementation first tests the length of the dynamic node and if the activation index is smaller than the activation node length, it returns without populating the linked list.
However, when it returns, it may be the case that a different thread has updated the linked list length but not yet populated the list.
Therefore the following write will fail because the element is not yet allocated.
The solution is to ensure that when the function returns the list is populated.