[Refactor] [lang] Add "ti.field" and "ti.Matrix.field" for future deprecation of "ti.var" #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archibate
changed the title
k-ye
approved these changes
Jul 16, 2020
| @@ -285,8 +285,14 @@ def __repr__(self): | |||
| root = Root() | |||
|
|
|||
|
|
|||
| @python_scope | |||
| #@deprecated('ti.var', 'ti.field') | |||
There was a problem hiding this comment.
Are these @deprecated commented out on purpose?
There was a problem hiding this comment.
Yes, we don't want to throw out tons of warnings yet, before it's fully deprecated from tests and examples. The #@ is just a reminder, this is to be deprecated in the future.
yuanming-hu
reviewed
Jul 16, 2020
Please see #1500, we will only uncomment this after all docs, tests, examples, are adopt to |
yuanming-hu
approved these changes
Jul 16, 2020
This was referenced Jul 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #1500:2.1
[Click here for the format server]