-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Remove the never used 'tid' command #1494
[cli] Remove the never used 'tid' command #1494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- It seems
tid
works in my environment:
(py-taichi-dev) ➜ ~ tid
[Taichi] mode=development
[Taichi] preparing sandbox at /var/folders/jr/_8tzt9ys77z10wt2kx09vyg40000gn/T/taichi-dsvhetv7
[Taichi] <dev mode>, llvm 8.0.1, commit f920fe99, python 3.7.3
*******************************************
** Taichi Programming Language **
*******************************************
***************** Debug Mode *****************
usage:
baseline |-> Archive current benchmark result as baseline
but if it's not being used by any stuff, 👍 to remove it for clarity.
- I believe most Unix systems provided env in /usr/bin, including macOS, but I'm not sure if itimproves the protability as I haven't checked how
PYTHON_EXECUTABLE_PATH
is generated now.
This comment has been minimized.
This comment has been minimized.
if not gpu: | ||
print('Linux release must ship with the CUDA backend.') | ||
sys.exit(-1) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm: @yuanming-hu Does this have fatal drawback?
I just want to run ti dist
on my non-CUDA laptop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this given that v0.6.19 is already released, ff2 revert me if you don't like this.
Related issue = #
[Click here for the format server]
tid
command:We already have
ti debug
and thedebug
argument inmain
seems useless...In fact, it's already not functional at all:
Use
#!/usr/bin/env python3
instead of#!${PYTHON_EXECUTABLE}
:Well, what if one use anaconda python3?
The PYTHON_EXECUTABLE is determinated by the buildbots, I don't think it's always the same as end-users...
In contrast,
/usr/bin/env
will automatically search forpython3
in currentPATH
, which will maketi
command work in anaconda python3.@k-ye Just to confirm, is
/usr/bin/env
always available on Mac?Make Linux users without CUDA able to use
ti dist
.I thought our Linux buildbot have constant CUDA support? So no need for this confirm?