Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] [lang] "ti.sqr(x)" is now fully deprecated #1476

Merged

Conversation

archibate
Copy link
Collaborator

@archibate archibate force-pushed the fully-deprecate-deprecated-functions branch from 56ce802 to baee9f2 Compare July 12, 2020 07:42
Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Maybe some users will be affected by this, but it should be easy to figure out..)

docs/debugging.rst Outdated Show resolved Hide resolved
Co-authored-by: Ye Kuang <k-ye@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #1476 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1476   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files          38       38           
  Lines        5422     5419    -3     
  Branches      955      955           
=======================================
- Hits         3628     3626    -2     
+ Misses       1632     1631    -1     
  Partials      162      162           
Impacted Files Coverage Δ
python/taichi/lang/ops.py 93.12% <ø> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ab837...e0a7cf6. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks.

taichi/python/export_lang.cpp Outdated Show resolved Hide resolved
Co-authored-by: Yuanming Hu <yuanming-hu@users.noreply.github.com>
@archibate archibate merged commit a63714c into taichi-dev:master Jul 13, 2020
@FantasyVR FantasyVR mentioned this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants