[Lang] Make tensor indicing automatically cast to int32 and raise an warning #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archibate
force-pushed
the
indicing-automatically-cast-into-int32
branch
from
c5adefe to
513dd52
Compare
archibate
commented
Jul 10, 2020
| stmt->name(), stmt->ptr->ret_data_type_name(), | ||
| old_data->ret_data_type_name(), stmt->id); | ||
| fmt::print(stmt->tb); | ||
| TI_WARN("\n{}", stmt->tb); |
There was a problem hiding this comment.
I change them as OFT, so that users don't see them when log_level is 'error'.
This comment has been minimized.
This comment has been minimized.
xumingkuan
approved these changes
Jul 10, 2020
|
|
||
| func() | ||
|
|
||
| assert a[6, 3] == 233 |
There was a problem hiding this comment.
Is it guaranteed that int32(6.66) == 6 on all platforms?
There was a problem hiding this comment.
Yes, that's how a Python int does, and I believe backends should follow that too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = close #1360
[Click here for the format server]
IIUC the index to tensor should always be int32 no matter what default_ip is?