[llvm] Use LLVM 10 for AppVeyor and GitHub actions #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archibate
reviewed
Jul 4, 2020
| wget https://github.com/yuanming-hu/taichi_assets/releases/download/llvm8/taichi-llvm-8.0.1-linux-x64.zip --waitretry=3 --tries=5 | ||
| unzip taichi-llvm-8.0.1-linux-x64.zip | ||
| wget https://github.com/taichi-dev/taichi_assets/releases/download/llvm10/taichi-llvm-10.0.0-linux.zip --waitretry=3 --tries=5 | ||
| unzip taichi-llvm-10.0.0-linux.zip |
There was a problem hiding this comment.
Cool! IIUC now all CI are running on LLVM 10? So will we deprecate LLVM 8 very soon? If not, you may try this:
Suggested change
| unzip taichi-llvm-10.0.0-linux.zip | |
| unzip taichi-llvm-${{ matrix.llvm }}-linux.zip |
and update the strategy of course, WDYT?
There was a problem hiding this comment.
Yeah, we will deprecate LLVM 8 very soon, so I'd just keep things simple here :-) Thanks for the review.
archibate
approved these changes
Jul 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #1402 +/- ##
=========================================
Coverage ? 66.72%
=========================================
Files ? 37
Lines ? 5196
Branches ? 933
=========================================
Hits ? 3467
Misses ? 1567
Partials ? 162 Continue to review full report at Codecov.
|
yuanming-hu
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue = #655
[Click here for the format server]