Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc][gui] Resolve deprecation warning (img.shape) #1369

Merged

Conversation

sanga-yoon
Copy link
Contributor


Since img.shape() in function set_image has been deprecated, changed to img.shape in order to get rid of DeprecationWarning.

Copy link
Collaborator

@archibate archibate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #1369 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1369   +/-   ##
=======================================
  Coverage   85.58%   85.58%           
=======================================
  Files          19       19           
  Lines        3371     3371           
  Branches      624      624           
=======================================
  Hits         2885     2885           
  Misses        356      356           
  Partials      130      130           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c633f7...196eb57. Read the comment docs.

Copy link
Member

@yuanming-hu yuanming-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, and welcome to the Taichi developer community! :-)

@yuanming-hu yuanming-hu merged commit 32d2159 into taichi-dev:master Jul 1, 2020
@FantasyVR FantasyVR mentioned this pull request Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants