Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt] Fix CFGNode::store_to_load_forwarding data type #1283

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

yuanming-hu
Copy link
Member

@yuanming-hu yuanming-hu commented Jun 19, 2020

Related issue = #656
Related PR = #1248

This subtle bug may cause later constant folding pass to fail.

[Click here for the format server]


@yuanming-hu yuanming-hu requested a review from xumingkuan June 19, 2020 17:40
Copy link
Contributor

@xumingkuan xumingkuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #1283 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1283   +/-   ##
=======================================
  Coverage   65.77%   65.77%           
=======================================
  Files          36       36           
  Lines        5063     5063           
  Branches      929      929           
=======================================
  Hits         3330     3330           
  Misses       1561     1561           
  Partials      172      172           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 265e414...c0e14a9. Read the comment docs.

@yuanming-hu yuanming-hu merged commit 11b6185 into taichi-dev:master Jun 19, 2020
@FantasyVR FantasyVR mentioned this pull request Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants