Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable vulkan validation layer in CI #6807

Closed
ailzhang opened this issue Dec 5, 2022 · 0 comments
Closed

Enable vulkan validation layer in CI #6807

ailzhang opened this issue Dec 5, 2022 · 0 comments
Assignees
@jim19930609
Labels
AOT vulkan Vulkan backend
Milestone
v1.4.0

Comments

@ailzhang
Copy link
Contributor

ailzhang commented Dec 5, 2022

We'll need to fix existing errors and enable crashing on error in the end.
@ailzhang ailzhang added vulkan Vulkan backend AOT labels Dec 5, 2022
@ailzhang ailzhang added this to the v1.4.0 milestone Dec 5, 2022
@taichi-gardener taichi-gardener moved this to Untriaged in Taichi Lang Dec 5, 2022
@jim19930609 jim19930609 self-assigned this Dec 5, 2022
@turbo0628 turbo0628 moved this from Untriaged to Todo in Taichi Lang Dec 9, 2022
@FantasyVR FantasyVR moved this from Todo to In Progress in Taichi Lang Dec 16, 2022
@jim19930609 jim19930609 mentioned this issue Dec 19, 2022
Merged
jim19930609 added a commit that referenced this issue Dec 22, 2022
@jim19930609
[aot] Fix validation warning: OpImageFetch should operate on OpImage …
22dbcd4 
…instead of OpSampledImage (#6925)

Issue: #6807

### Brief Summary
`spv::OpImageFetch` should take `OpImage` instead of `OpSampledImage` as
operand. Therefore we extract the underlying `OpImage` during code
generation for `TextureOpStmt("fetch")`
@github-project-automation github-project-automation bot moved this from In Progress to Done in Taichi Lang Jan 4, 2023
@jim19930609 jim19930609 mentioned this issue Jan 4, 2023
Merged
quadpixels pushed a commit to quadpixels/taichi that referenced this issue May 13, 2023
@jim19930609 @quadpixels
[aot] Fix validation warning: OpImageFetch should operate on OpImage …
0f1c18d 
…instead of OpSampledImage (taichi-dev#6925)

Issue: taichi-dev#6807

### Brief Summary
`spv::OpImageFetch` should take `OpImage` instead of `OpSampledImage` as
operand. Therefore we extract the underlying `OpImage` during code
generation for `TextureOpStmt("fetch")`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jim19930609 jim19930609

Labels
AOT vulkan Vulkan backend
Projects
Taichi Lang
Status: Done
Milestone
v1.4.0
Development

No branches or pull requests
2 participants
@ailzhang @jim19930609