Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline cache should respect the caps set by ti.aot.Module() #6508

Closed
ailzhang opened this issue Nov 3, 2022 · 0 comments · Fixed by #6520
Closed

Offline cache should respect the caps set by ti.aot.Module() #6508

ailzhang opened this issue Nov 3, 2022 · 0 comments · Fixed by #6520
Assignees
@PGZXB
Labels
AOT potential bug Something that looks like a bug but not yet confirmed

Comments

@ailzhang
Copy link
Contributor

ailzhang commented Nov 3, 2022

An example to repro:
Run https://github.com/taichi-dev/taichi-aot-demo/blob/master/2_mpm88/assets/mpm88.py with a simple change: mod = ti.aot.Module(arch, caps=[]). This essentially means when compiling the shader for AOT module, no caps should be enabled so the generated shaders shouldn't include extensions like below:

               OpExtension "SPV_KHR_storage_buffer_storage_class"
               OpExtension "SPV_KHR_non_semantic_info"
               OpExtension "SPV_KHR_variable_pointers"
               OpExtension "SPV_EXT_shader_atomic_float_add"

cc: @PGZXB @jim19930609
@ailzhang ailzhang added potential bug Something that looks like a bug but not yet confirmed AOT labels Nov 3, 2022
@taichi-gardener taichi-gardener moved this to Untriaged in Taichi Lang Nov 3, 2022
@PGZXB PGZXB mentioned this issue Nov 4, 2022
Merged
@lin-hitonami lin-hitonami moved this from Untriaged to In Progress in Taichi Lang Nov 4, 2022
ailzhang pushed a commit that referenced this issue Nov 4, 2022
@PGZXB @pre-commit-ci
[bug] Fix that the cgraph doesn't respect the caps set by ti.aot.Modu…
38b8ef7 
…le() (#6520)

Issue: #6508 
This PR fixes #6508 but causes the bug reported in #5699 (only) when
enabling the offline cache.
Using `CacheManager` manage the compilation in `AotModuleBuilder` can
fix the bug. I will fix it in next PR.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Repository owner moved this from In Progress to Done in Taichi Lang Nov 4, 2022
quadpixels pushed a commit to quadpixels/taichi that referenced this issue May 13, 2023
@PGZXB @pre-commit-ci @quadpixels
[bug] Fix that the cgraph doesn't respect the caps set by ti.aot.Modu…
264345b 
…le() (taichi-dev#6520)

Issue: taichi-dev#6508 
This PR fixes taichi-dev#6508 but causes the bug reported in taichi-dev#5699 (only) when
enabling the offline cache.
Using `CacheManager` manage the compilation in `AotModuleBuilder` can
fix the bug. I will fix it in next PR.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PGZXB PGZXB

Labels
AOT potential bug Something that looks like a bug but not yet confirmed
Projects
Taichi Lang
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bug] Fix that the cgraph doesn't respect the caps set by ti.aot.Module() PGZXB/taichi
2 participants
@ailzhang @PGZXB