Alchemic Logs: Small improvements for eth_getLogs #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowfiend
force-pushed
the
alchemic-logs
branch
2 times, most recently
from
a243fc0 to
6cc2dfa
Compare
Shadowfiend
changed the title
Shadowfiend
force-pushed
the
alchemic-logs
branch
from
6cc2dfa to
9923b6a
Compare
Other providers impose various limits on eth_getLogs calls that can break lookups. Alchemy does not impose these, so use Alchemy for these calls. If the cost is too high, we can adjust differently via more complex fallbacks, but this solves the problem more neatly and will hopefully not spike costs too much.
There was a duplication of types between preferences/types and preferences/db, mostly due to a missed duplication way back when the preferences service was still being booted up. This commit eliminates the duplication, harmonizes the types, and re-exports appropriate external-facing types. No underlying functionality has changed.
Shadowfiend
force-pushed
the
alchemic-logs
branch
from
9923b6a to
af6d8e6
Compare
Shadowfiend
requested review from
jagodarybacka
and removed request for
ioay
Merged
Shadowfiend
added a commit
that referenced
this pull request
Nov 23, 2023
## What's Changed * Check connecting to dapp on different network after disconnecting by @michalinacienciala in #3654 * v0.51.0 by @Shadowfiend in #3652 * Fix typos by @xiaolou86 in #3668 * Alchemic Logs: Small improvements for eth_getLogs by @Shadowfiend in #3664 * Fix getting currently connected dapp info by @jagodarybacka in #3671 * Add static subcape link to the wallet by @jagodarybacka in #3670 * Fix e2e tests by @michalinacienciala in #3651 * Add Alchemy endpoint for Arbitrum Sepolia by @jagodarybacka in #3665 * Do notify: Set up base NotificationService by @Shadowfiend in #3666 ## New Contributors * @xiaolou86 made their first contribution in #3668 **Full Changelog**: v0.51.0...v0.52.0 Latest build: [extension-builds-3678](https://github.com/tahowallet/extension/suites/18415208655/artifacts/1067210815) (as of Wed, 22 Nov 2023 14:53:11 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focused on two quality-of-life improvements:
eth_getLogsto Alchemy. This bypasses certain restrictions on logs that exist on other providers we use and makes certain dApps much better/more functional (e.g. the Threshold dashboard). If we see too high a spike in usage, we can revert this back and come up with a different solution.PreferencesService. No user-facing changes here, it's all in type-land.Testing
0xafeacce4ad8b3b863ef72a7b7aa9d0e84ca71dfbas read-only, connect to https://dashboard.threshold.network/staking . Prior to this branch, the page should remain blank. After this branch, the page should fill in a “Stake - Native” entry with 58,333,338.75 T total staked balance.Latest build: extension-builds-3664 (as of Mon, 13 Nov 2023 22:08:36 GMT).