Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed assets reappear on the token list #3675

Closed
michalinacienciala opened this issue Nov 16, 2023 · 0 comments · Fixed by #3708
Closed

Removed assets reappear on the token list #3675

michalinacienciala opened this issue Nov 16, 2023 · 0 comments · Fixed by #3708
Labels
Type: Bug Something isn't working

Comments

@michalinacienciala
Copy link
Contributor

The once removed assets re-appear in the wallet soon after their removal. Happens for all removed assets (no matter if removed from the list of verified or unverified assets).

  1. Import the account with some unverified assets
  2. Go to the unverified asset ant click Verify asset -> Don't show (either from token list or token details)
  3. Observe token being removed from the list (OK) and soon being listed again (NOOK).
Screen.Recording.2023-11-16.at.11.37.12.mov

Tested on:
bnbspider2.crypto and 0x0581470a8b62bd35dbf121a6329d43e7edd20fc7 accounts
Taho 0.51.0 (from Chrome store) and a local build from fix-e2e-tests
@michalinacienciala michalinacienciala added the Type: Bug Something isn't working label Nov 16, 2023
@michalinacienciala michalinacienciala mentioned this issue Nov 16, 2023
Merged
@michalinacienciala michalinacienciala mentioned this issue Dec 15, 2023
Merged
2 tasks
@jagodarybacka jagodarybacka mentioned this issue Dec 15, 2023
Merged
xpaczka added a commit that referenced this issue Dec 21, 2023
@xpaczka
Fix hiding unverified assets (#3708)
8bc0d63 
Resolves #3675

### What has been done

The problem was that although we were removing custom assets correctly
from the redux and marking them as removed in the databese then they
were added back with next balances update.

- added `removed` filed to metadata type for consistency
- fixed the issue: filter out balance update against a list of removed
custom assets

### Testing

Try to reproduce steps from the linked issue. The item that was removed
shouldn't go back anymore even after reload.

Latest build:
[extension-builds-3708](https://github.com/tahowallet/extension/suites/19204939996/artifacts/1126356154)
(as of Wed, 20 Dec 2023 11:38:46 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hiding unverified assets tahowallet/extension
1 participant
@michalinacienciala