Add new realm to map #675
Merged
Add new realm to map #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I just noticed - on the realm modal only the "main land" of the realm is visible and the mini island are missing
|
jagodarybacka
requested changes
Nov 16, 2023
src/shared/constants/realms.ts
Outdated
| realm4, | ||
| realm7, | ||
| realm9, | ||
| realm19, | ||
| realm22, | ||
| ] | ||
|
|
||
| export const ADDITIONAL_REALMS_MAP_DATA: RealmMapData[] = [realm16] | ||
|
|
||
| export const REALMS_MAP_DATA = process.env.SHOW_ADDITIONAL_REALMS |
There was a problem hiding this comment.
it must be process.env.SHOW_ADDITIONAL_REALMS === "true" becuase env vars are strings so SHOW_ADDITIONAL_REALMS="false"will break it
|
Will merge it tomorrow to not bloat the batch for QA before the XP drop |
ioay
reviewed
Nov 16, 2023
| </Fragment> | ||
| ))} | ||
| </defs> | ||
| {pathData.paths.map((_, index) => ( |
There was a problem hiding this comment.
Let's put it in one iteration of array mapping.
jagodarybacka
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #637
What has been done:
useMultiRefhookMake sure to add to
.envto see the new realm (think it is quite universal for future additions):SHOW_ADDITIONAL_REALMS="true"