Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENS names are lagging to become visible #823

Closed
jagodarybacka opened this issue Dec 1, 2023 · 0 comments · Fixed by #879
Closed

ENS names are lagging to become visible #823

jagodarybacka opened this issue Dec 1, 2023 · 0 comments · Fixed by #879
Assignees
@xpaczka

Comments

@jagodarybacka
Copy link
Contributor

  1. Clear localstorage
  2. Add account with an ens/uns name
  3. Wait a minute
  4. Check localstorage to mkae sure the name was cached

Result: name is not replacing the address in the UI even if it is available in the cache
Expected: name should be visible in the UI as soon as it is loaded
@jagodarybacka jagodarybacka mentioned this issue Dec 1, 2023
Open
@ioay ioay self-assigned this Dec 4, 2023
@ioay ioay unassigned ioay Dec 11, 2023
@xpaczka xpaczka self-assigned this Dec 12, 2023
@xpaczka xpaczka mentioned this issue Dec 12, 2023
Merged
4 tasks
jagodarybacka added a commit that referenced this issue Dec 14, 2023
@jagodarybacka
Fix ENS and UNS names not visible in UI (#879)
80e931b 
## Issues connected

Resolves #823 

## What has been done

- Fixed ENS and UNS names not updated automatically (without reload)
- Added `useCachedWalletName` hook

## Testing

- [x] Clear `localStorage`
- [x] Connect wallet
- [x] After a short interval, account name is automatically updated
- [x] Reload the page, the name is still visible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xpaczka xpaczka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ENS and UNS names not visible in UI tahowallet/dapp
3 participants
@jagodarybacka @ioay @xpaczka