Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Ledger problems #567

Closed
jagodarybacka opened this issue Oct 27, 2023 · 6 comments
Closed

Investigate Ledger problems #567

jagodarybacka opened this issue Oct 27, 2023 · 6 comments
Assignees

Comments

@jagodarybacka
Copy link
Contributor

No description provided.

@michalinacienciala
Copy link
Contributor

michalinacienciala commented Oct 27, 2023

I did encounter some problems when testing staking using Ledger. My wallet address: 0x43866d77672dd19252e8ea2274ecece9c62d3262 (0,01 ETH, 10 TAHO).

TEST 1. Try to stake 2 TAHO:

Got Transaction failed, try again in dApp, logs:

Error processing request Error: processing response error (body="{\"jsonrpc\":\"2.0\",\"id\":781,\"error\":{\"code\":3,\"message\":\"execution reverted: Transfer amount exceeds spender allowance\",\"data\":\"0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000295472616e7366657220616d6f756e742065786365656473207370656e64657220616c6c6f77616e63650000000000000000000000000000000000000000000000\"}}\n", error={"code":3,"data":"0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000295472616e7366657220616d6f756e742065786365656473207370656e64657220616c6c6f77616e63650000000000000000000000000000000000000000000000"}, requestBody="{\"method\":\"eth_estimateGas\",\"params\":[{\"from\":\"0x43866d77672dd19252e8ea2274ecece9c62d3262\",\"to\":\"0x42a0b5cab976d7a2a0038138dd1279b96b73f029\",\"data\":\"0xa694fc3a0000000000000000000000000000000000000000000000001bc16d674ec80000\"}],\"id\":781,\"jsonrpc\":\"2.0\"}", requestMethod="POST", url="https://sepolia-rollup.arbitrum.io/rpc", code=SERVER_ERROR, version=web/5.7.1)
    at Logger.makeError (index.js:224:23)
    at Logger.throwError (index.js:233:20)
    at index.js:261:32
    at Generator.next (<anonymous>)
    at fulfilled (index.js:5:58)

No successful tx in wallet history,

TEST 2. Try to stake 2 TAHO:

Staking successful, two transactions (Token approval & Send) in wallet history

TEST 3. Try to stake 3 TAHO:

Got Transaction failed, try again in dapp after signing the Contract interaction tx in Ledger. Logs:

logger.ts:208 Error encountered! ledgerID: LEDGER_NANO_S_0x43866d77672dd19252e8ea2274ecece9c62d3262 transactionRequest: [object Object] error: Error: transaction.chainId/signature.v mismatch (argument="signature", value={"r":"0x2b069505b96a272c34d3820efdec59442b4424d4362bec7af2e368150df6a9c3","s":"0x4efc2c085a3688549d2ede91647168de8dbdd45434ab602fcefcaf69c906aaf6","v":843518}, code=INVALID_ARGUMENT, version=transactions/5.7.0)

and

Error signing transaction Error: transaction.chainId/signature.v mismatch (argument="signature", value={"r":"0x2b069505b96a272c34d3820efdec59442b4424d4362bec7af2e368150df6a9c3","s":"0x4efc2c085a3688549d2ede91647168de8dbdd45434ab602fcefcaf69c906aaf6","v":843518}, code=INVALID_ARGUMENT, version=transactions/5.7.0)
    at Logger.makeError (index.js:224:23)
    at Logger.throwError (index.js:233:20)
    at Logger.throwArgumentError (index.js:236:21)
    at _serialize (index.js:204:20)
    at serialize (index.js:221:16)
    at index.ts:415:35

and

ProviderBridgeService.routeContentScriptRPCRequest
Error processing request

Only Token approval transaction visible in the wallet history

Screen.Recording.2023-10-27.at.10.11.46.mov

@michalinacienciala
Copy link
Contributor

michalinacienciala commented Oct 27, 2023

TEST 4. Try to stake 3 TAHO:

Did not get the Approve asset spend transaction, as I already approved 3 TAHO spending in the test no. 3. When signing the Contract interaction tx in Ledger, got the same errors as in test no. 3.

Screen.Recording.2023-10-27.at.11.16.36.mov

TEST 5. Try to stake 3 TAHO:

Did not get the Approve asset spend transaction, as I already approved 3 TAHO spending in the test no. 3. When signing the Contract interaction this time transaction was successful, no errors in logs, Contract interaction transaction visible in the wallet history.

Screen.Recording.2023-10-27.at.11.40.22.mov

@michalinacienciala
Copy link
Contributor

TESTS 6-12:

TEST 6: Stake 1 TAHO. Both txs successful.
TEST 7: Stake 2 TAHO. Approve asset spend successful, Contract interaction failed with transaction.chainId/signature.v mismatch
TEST 8: Stake 2 TAHO. Contract interaction failed with transaction.chainId/signature.v mismatch
TEST 9: Stake 2 TAHO. Contract interaction failed with transaction.chainId/signature.v mismatch
TEST 10: Stake 2 TAHO. Contract interaction failed with transaction.chainId/signature.v mismatch
TEST 11: Stake 2 TAHO. Contract interaction failed with transaction.chainId/signature.v mismatch
TEST 12: Stake 2 TAHO. Contract interaction failed with transaction.chainId/signature.v mismatch

Screen.Recording.2023-10-27.at.11.47.02.mov

@michalinacienciala
Copy link
Contributor

Issue with transaction.chainId/signature.v mismatch moved to extension repo: tahowallet/extension#3647

@jagodarybacka
Copy link
Contributor Author

Can we close this task already @michalinacienciala - the fix for mismatch thing is included in the most recent wallet release

@michalinacienciala
Copy link
Contributor

Can we close this task already @michalinacienciala - the fix for mismatch thing is included in the most recent wallet release

The fix proved to be not sufficient - I've reopened tahowallet/extension#3647. But yes, I think we can close #567, as the issue is tracked in #567 and there's no issue on the dApp's side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants