Upgrade to Tokio 1.x #213
Merged
Upgrade to Tokio 1.x #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hyper 0.14 was released, upgraded to Tokio 1.0: |
|
I think the blocker was resolved here seanmonstar/reqwest#1076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokio1reqwest0.11mpscsync implementation withflumebased on feedback from @Darksonn in Add back mpsc try_recv tokio-rs/tokio#3350 (comment) (which improved the accuracy of the throttle and required an adjustment to the throttle gaggle test assertions)I ran some performance comparisons, confirming that updating to Tokio 1.x and switching to Flume didn't cause any performance regressions: https://docs.google.com/spreadsheets/d/1T9SsgveIm1JFRvTcTFWBSPgweBthYiR5apmyHdb92eA/edit#gid=0 (It seems to be consistently slightly faster)